Created new method welcomeIfNewNode in protocol.
This commit consolidates the maybeTransferKeyValues and addContact calls into the transferKeyValues method and renames it.
This commit is contained in:
parent
2f363cba84
commit
237d89b6b6
@ -32,14 +32,12 @@ class KademliaProtocol(RPCProtocol):
|
||||
|
||||
def rpc_ping(self, sender, nodeid):
|
||||
source = Node(nodeid, sender[0], sender[1])
|
||||
self.maybeTransferKeyValues(source)
|
||||
self.router.addContact(source)
|
||||
self.welcomeIfNewNode(source)
|
||||
return self.sourceNode.id
|
||||
|
||||
def rpc_store(self, sender, nodeid, key, value):
|
||||
source = Node(nodeid, sender[0], sender[1])
|
||||
self.maybeTransferKeyValues(source)
|
||||
self.router.addContact(source)
|
||||
self.welcomeIfNewNode(source)
|
||||
self.log.debug("got a store request from %s, storing value" % str(sender))
|
||||
self.storage[key] = value
|
||||
return True
|
||||
@ -47,15 +45,13 @@ class KademliaProtocol(RPCProtocol):
|
||||
def rpc_find_node(self, sender, nodeid, key):
|
||||
self.log.info("finding neighbors of %i in local table" % long(nodeid.encode('hex'), 16))
|
||||
source = Node(nodeid, sender[0], sender[1])
|
||||
self.maybeTransferKeyValues(source)
|
||||
self.router.addContact(source)
|
||||
self.welcomeIfNewNode(source)
|
||||
node = Node(key)
|
||||
return map(tuple, self.router.findNeighbors(node, exclude=source))
|
||||
|
||||
def rpc_find_value(self, sender, nodeid, key):
|
||||
source = Node(nodeid, sender[0], sender[1])
|
||||
self.maybeTransferKeyValues(source)
|
||||
self.router.addContact(source)
|
||||
self.welcomeIfNewNode(source)
|
||||
value = self.storage.get(key, None)
|
||||
if value is None:
|
||||
return self.rpc_find_node(sender, nodeid, key)
|
||||
@ -81,9 +77,10 @@ class KademliaProtocol(RPCProtocol):
|
||||
d = self.store(address, self.sourceNode.id, key, value)
|
||||
return d.addCallback(self.handleCallResponse, nodeToAsk)
|
||||
|
||||
def transferKeyValues(self, node):
|
||||
def welcomeIfNewNode(self, node):
|
||||
"""
|
||||
Given a new node, send it all the keys/values it should be storing.
|
||||
Given a new node, send it all the keys/values it should be storing,
|
||||
then add it to the routing table.
|
||||
|
||||
@param node: A new node that just joined (or that we just found out
|
||||
about).
|
||||
@ -94,6 +91,7 @@ class KademliaProtocol(RPCProtocol):
|
||||
is closer than the closest in that list, then store the key/value
|
||||
on the new node (per section 2.5 of the paper)
|
||||
"""
|
||||
if self.router.isNewNode(node):
|
||||
ds = []
|
||||
for key, value in self.storage.iteritems():
|
||||
keynode = Node(digest(key))
|
||||
@ -103,12 +101,9 @@ class KademliaProtocol(RPCProtocol):
|
||||
thisNodeClosest = self.sourceNode.distanceTo(keynode) < neighbors[0].distanceTo(keynode)
|
||||
if len(neighbors) == 0 or (newNodeClose and thisNodeClosest):
|
||||
ds.append(self.callStore(node, key, value))
|
||||
self.router.addContact(node)
|
||||
return defer.gatherResults(ds)
|
||||
|
||||
def maybeTransferKeyValues(self, node):
|
||||
if self.router.isNewNode(node):
|
||||
self.transferKeyValues(node)
|
||||
|
||||
def handleCallResponse(self, result, node):
|
||||
"""
|
||||
If we get a response, add the node to the routing table. If
|
||||
@ -116,9 +111,7 @@ class KademliaProtocol(RPCProtocol):
|
||||
"""
|
||||
if result[0]:
|
||||
self.log.info("got response from %s, adding to router" % node)
|
||||
if self.router.isNewNode(node):
|
||||
self.transferKeyValues(node)
|
||||
self.router.addContact(node)
|
||||
self.welcomeIfNewNode(node)
|
||||
else:
|
||||
self.log.debug("no response from %s, removing from router" % node)
|
||||
self.router.removeContact(node)
|
||||
|
Loading…
Reference in New Issue
Block a user